-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixing chart version number in chart docs #845
Conversation
found this while fixing #829 in a cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
Could you remove the changes from charts/
folder and instead update the helm chart README.md in the manifest_staging/charts folder, where we host the staging charts and deployment yamls. Any changes made in charts
folder will trigger the action to repackage helm charts and I want to avoid building it for doc change. All the yaml and readme changes will be promoted into the released charts folder with the next release.
@aramase fixed 👍 |
@sukhdeepsingh1 All the charts are hosted in gh-pages: https://github.com/Azure/secrets-store-csi-driver-provider-azure/tree/gh-pages. Refer to the installation guide for the helm chart URL. Also, there is no |
@aramase Ah, ok, thanks for clarifying |
Reason for Change:
Latest chart version is 1.1.1 not 1.1.0
Requirements
Issue Fixed:
Does this change contain code from or inspired by another project?
If "Yes," did you notify that project's maintainers and provide attribution?
Special Notes for Reviewers: